Hmm, so copy tags/relation memberships to the subject and remove them from the reference, but not move the subject? Would it make sense to copy tags/memberships but NOT remove them from the reference? One assumption I have is that if the reference is from another layer, I'll never touch that layer at all (let me know if you think I shouldn't assume this).
Ideally making this choice should be on a per match basis, meaning that it shouldn't be a button on the toggle dialog but rather it should appear on the tag/membership conflict resolution dialog, which means changing that dialog (currently I use it as from JOSM core).
The actions that one might want to do seem to be:
- Replace geometry of subject and move tags/memberships to subject (default, removing reference if it's in the same layer)
- Move tags/memberships from reference to subject (your request, leaving reference in place with remaining tags/memberships)
- Copy tags/memberships from reference to subject (leaving reference untouched)
- Replace geometry of subject (and don't copy tags, removing reference if it's in the same layer)
Anything else I'm missing? This maybe can be distilled down to the following, each of which can be represented by a checkbox:
- Replace geometry (removes reference if it's in the same layer as the subject)
- Copy tags from reference to subject
- Remove copied tags from reference (only if 2 is checked)
- Remove reference
By default 1, 2 and 4 will be checked (3 is N/A). If 1 is checked, 4 will be checked (so no duplicate nodes/geometry). If 2 is checked the tag/membership tables will be disabled. For 3 to be checked, 2 must be checked. If 4 is checked, 3 will be disabled.
Seems complicated, so if there's a smarter way please let me know.
